Fix #14684: FP unreadVariable with auto and brace-init#8508
Open
ludviggunne wants to merge 2 commits intocppcheck-opensource:mainfrom
Open
Fix #14684: FP unreadVariable with auto and brace-init#8508ludviggunne wants to merge 2 commits intocppcheck-opensource:mainfrom
ludviggunne wants to merge 2 commits intocppcheck-opensource:mainfrom
Conversation
| if (!parent->astOperand1()) | ||
| return; | ||
|
|
||
| if (Token::Match(parent->astOperand1()->previous(), "auto %var% {")) { |
Collaborator
There was a problem hiding this comment.
There could be variations like auto&& or auto const&.
Is the ValueType set correctly for e.g. T t{ 1 }?
Collaborator
Author
There was a problem hiding this comment.
Is the T from a template? I would assume it would be set to whatever it is in the instantiation, but i can double check.
Collaborator
There was a problem hiding this comment.
Is the
Tfrom a template? I would assume it would be set to whatever it is in the instantiation, but i can double check.
I was thinking about e.g. struct T { int i; };. If that works, we might find a way to make auto work as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.